[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] qemu-img: Check for backing image if specifi
Re: [Qemu-block] [PATCH v2] qemu-img: Check for backing image if specified during create
Tue, 9 May 2017 14:21:12 -0400
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0
On 05/09/2017 02:19 PM, Eric Blake wrote:
> On 05/09/2017 01:17 PM, Eric Blake wrote:
>> On 05/09/2017 01:09 PM, John Snow wrote:
>>> Or, rather, force the open of a backing image if one was specified
>>> for creation. Using a similar -unsafe option as rebase, allow qemu-img
>>> to ignore the backing file validation if possible.
>>> +++ b/qemu-img.c
>>> @@ -145,9 +145,11 @@ static void QEMU_NORETURN help(void)
>>> " 'snapshot_id_or_name' is deprecated, use 'snapshot_param'\n"
>>> " instead\n"
>>> " '-c' indicates that target image must be compressed (qcow
>>> format only)\n"
>>> - " '-u' enables unsafe rebasing. It is assumed that old and new
>>> backing file\n"
>>> - " match exactly. The image doesn't need a working backing
>>> file before\n"
>>> - " rebasing in this case (useful for renaming the backing
>>> + " '-u' allows unsafe backing chains. For rebasing, it is
>>> assumed that old and new\n"
>>> + " backing file match exactly. The image doesn't need a
>>> working backing file\n"
>>> + " before rebasing in this case (useful for renaming the
>>> backing file)\n"
> Also, a '.' to end this sentence would be nice.
I can respin if that's more convenient, as I am assuming Max or Kevin
will have something to say.
If not, either edit it if that's easier, or ask me to re-spin.
>>> + " For image creation, allow creating without attempting
>> Missing \n
>> With that fixed,
>> Reviewed-by: Eric Blake <address@hidden>