|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-block] [PATCH 4/7] curl: split curl_find_state/curl_init_state |
Date: | Thu, 11 May 2017 15:49:02 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 10/05/2017 19:26, Max Reitz wrote: >> + if (curl_init_state(s, state) < 0) { >> + curl_clean_state(state); > > We could also initialize state to NULL and call curl_clean_state() under > out: if state != NULL. Then again, it would only save us two > curl_clean_state() instances... > > So I'll leave it to you and unconditionally give a > > Reviewed-by: Max Reitz <address@hidden> Makes sense, but OTOH you could also move locking to curl_co_preadv and get rid of "out" altogether. So for now I left curl_clean_state here. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |