[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 2/6] replication: add shared-disk and shared-

From: Hailiang Zhang
Subject: Re: [Qemu-block] [PATCH v4 2/6] replication: add shared-disk and shared-disk-id options
Date: Fri, 12 May 2017 14:28:41 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 2017/5/12 3:08, Stefan Hajnoczi wrote:
On Wed, Apr 12, 2017 at 10:05:17PM +0800, zhanghailiang wrote:
We use these two options to identify which disk is

Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
- Add proper comment for primary_disk (Stefan)
- Move g_free(s->shared_disk_id) to the common fail process place (Stefan)
- Fix comments for these two options
  block/replication.c  | 43 +++++++++++++++++++++++++++++++++++++++++--
  qapi/block-core.json | 10 +++++++++-
  2 files changed, 50 insertions(+), 3 deletions(-)
Aside from the ongoing discussion about this patch...

Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks,  I'll fix the related problems found by changlong.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]