[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty()

From: Juan Quintela
Subject: Re: [Qemu-block] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes
Date: Wed, 17 May 2017 13:37:02 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Eric Blake <address@hidden> wrote:
> Half the callers were already scaling bytes to sectors; the other
> half can eventually be simplified to use byte iteration.  Both
> callers were already using the result as a bool, so make that
> explicit.  Making the change also makes it easier for a future
> dirty-bitmap patch to offload scaling over to the internal hbitmap.
> Remember, asking whether a byte is dirty is effectively asking
> whether the entire granularity containing the byte is dirty, since
> we only track dirtiness by granularity.
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: John Snow <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]