[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_t
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir |
Date: |
Wed, 24 May 2017 08:34:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/23/2017 11:10 PM, Philippe Mathieu-Daudé wrote:
> Hi Hervé,
>
> On 05/22/2017 06:11 PM, Hervé Poussineau wrote:
>> - offset_to_bootsector is the number of sectors up to FAT bootsector
>> - offset_to_fat is the number of sectors up to first File Allocation
>> Table
>> - offset_to_root_dir is the number of sectors up to root directory sector
>
> Eventually your commit description can end here, adding the 3 following
> lines below the "---" separator.
No. Stuff after the --- is intended for things that are useful to
reviewers, but not helpful in the long run. But in this case:
>
>> Replace first_sectors_number - 1 by offset_to_bootsector.
Knowing the conversion that was made DOES make it easier to read this
patch, even in the long run. So this information belongs before the ---.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 00/13] vvfat: misc fixes for read-only mode, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 08/13] vvfat: correctly create long names for non-ASCII filenames, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 06/13] vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 12/13] vvfat: handle KANJI lead byte 0xe5, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1', Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 09/13] vvfat: correctly create base short names for non-ASCII filenames, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert, Hervé Poussineau, 2017/05/22