[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v7 02/20] block: add ability to set a prefix for

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v7 02/20] block: add ability to set a prefix for opt names
Date: Thu, 25 May 2017 14:21:47 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 05/25/2017 11:38 AM, Daniel P. Berrange wrote:
> When integrating the crypto support with qcow/qcow2, we don't
> want to use the bare LUKS option names "hash-alg", "key-secret",
> etc. We need to namespace them to match the nested QAPI schema.
> e.g. "encrypt.hash-alg", "encrypt.key-secret"
> so that they don't clash with any general qcow options at a later
> date.
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  block/crypto.c | 16 ++++++++--------
>  block/crypto.h | 40 ++++++++++++++++++++--------------------
>  2 files changed, 28 insertions(+), 28 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]