[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 08/29] qed: Remove callback from qe

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 08/29] qed: Remove callback from qed_copy_from_backing_file()
Date: Fri, 26 May 2017 16:51:26 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 05/26/2017 03:21 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qed.c | 57 +++++++++++++++++++++++----------------------------------
>  1 file changed, 23 insertions(+), 34 deletions(-)

>  /**
> - * Populate back untouched region of new data cluster
> + * Populate untouched regions of new data cluster
>   */
> -static void qed_aio_write_postfill(void *opaque, int ret)
> +static void qed_aio_write_cow(void *opaque, int ret)
>  {

It may be worth a mention in the commit message that you are renaming
things to use more common terminology in the process (in part because
you reduced a chained callback into one: qed_aio_write_alloc called
qed_aio_write_prefill called qed_aio_write_postfill).  Up to you.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]