[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PULL 12/15] qemu-img: Fix leakage of options on error

From: Kevin Wolf
Subject: [Qemu-block] [PULL 12/15] qemu-img: Fix leakage of options on error
Date: Mon, 29 May 2017 17:06:51 +0200

From: Fam Zheng <address@hidden>

Reported by Coverity.

Signed-off-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Max Reitz <address@hidden>
 qemu-img.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qemu-img.c b/qemu-img.c
index 0bf941b..5aef8ef 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -295,6 +295,7 @@ static BlockBackend *img_open_opts(const char *optstr,
         if (qdict_haskey(options, BDRV_OPT_FORCE_SHARE)
             && !qdict_get_bool(options, BDRV_OPT_FORCE_SHARE)) {
             error_report("--force-share/-U conflicts with image options");
+            QDECREF(options);
             return NULL;
         qdict_put(options, BDRV_OPT_FORCE_SHARE, qbool_from_bool(true));

reply via email to

[Prev in Thread] Current Thread [Next in Thread]