Re: [Qemu-block] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

[Stefan Hajnoczi]

On Tue, Jun 13, 2017 at 10:57:26PM +0200, Max Reitz wrote:
> uri_parse(...)->scheme may be NULL. In fact, probably every field may be
> NULL, and the callers do test this for all of the other fields but not
> for scheme (except for block/gluster.c; block/vxhs.c does not access
> that field at all).
> 
> We can easily fix this by using g_strcmp0() instead of strcmp().
> 
> Cc: address@hidden
> Signed-off-by: Max Reitz <address@hidden>
> ---
> v2:
> - Fix all affected block drivers, not just nfs [Peter]
> - Use g_strcmp0() [Markus]
> ---
>  block/nbd.c      | 6 +++---
>  block/nfs.c      | 2 +-
>  block/sheepdog.c | 6 +++---
>  block/ssh.c      | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature