[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC v1 1/4] util/aio-win32: Only select on what we are
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [RFC v1 1/4] util/aio-win32: Only select on what we are actually waiting for |
Date: |
Thu, 29 Jun 2017 14:22:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 28/06/2017 01:57, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <address@hidden>
> Acked-by: Edgar E. Iglesias <address@hidden>
> ---
>
> util/aio-win32.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/util/aio-win32.c b/util/aio-win32.c
> index bca496a47a..949979c2f5 100644
> --- a/util/aio-win32.c
> +++ b/util/aio-win32.c
> @@ -71,6 +71,7 @@ void aio_set_fd_handler(AioContext *ctx,
> }
> } else {
> HANDLE event;
> + long bitmask = 0;
>
> if (node == NULL) {
> /* Alloc and insert if it's not already there */
> @@ -95,10 +96,16 @@ void aio_set_fd_handler(AioContext *ctx,
> node->io_write = io_write;
> node->is_external = is_external;
>
> + if (io_read) {
> + bitmask |= FD_READ;
> + }
> +
> + if (io_write) {
> + bitmask |= FD_WRITE;
> + }
The read case should also include FD_ACCEPT, and the write case should
also include FD_CONNECT. FD_CLOSE probably also goes under "read",
since it's signaled when read()/recv() return 0.
FD_OOB is unnecessary, indeed.
Paolo
> event = event_notifier_get_handle(&ctx->notifier);
> - WSAEventSelect(node->pfd.fd, event,
> - FD_READ | FD_ACCEPT | FD_CLOSE |
> - FD_CONNECT | FD_WRITE | FD_OOB);
> + WSAEventSelect(node->pfd.fd, event, bitmask);
> }
>
> qemu_lockcnt_unlock(&ctx->list_lock);
>
- Re: [Qemu-block] [Qemu-devel] [RFC v1 2/4] util/oslib-win32: Remove invalid check, (continued)
[Qemu-block] [RFC v1 4/4] util/oslib-win32: Recursivly pass the timeout, Alistair Francis, 2017/06/27
[Qemu-block] [RFC v1 1/4] util/aio-win32: Only select on what we are actually waiting for, Alistair Francis, 2017/06/27