[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 12/17] migration: add postcopy migration of dirt

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps
Date: Wed, 5 Jul 2017 12:24:01 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

16.02.2017 16:04, Fam Zheng wrote:
+            dbms->node_name = bdrv_get_node_name(bs);
+            if (!dbms->node_name || dbms->node_name[0] == '\0') {
+                dbms->node_name = bdrv_get_device_name(bs);
+            }
+            dbms->bitmap = bitmap;
What protects the case that the bitmap is released before migration completes?

What is the source of such deletion? qmp command? Theoretically possible.

I see the following variants:

1. additional variable BdrvDirtyBItmap.migration, which forbids bitmap deletion

2. make bitmap anonymous (bdrv_dirty_bitmap_make_anon) - it will not be available through qmp

what do you think?

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]