[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for rea
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode
Thu, 6 Jul 2017 07:27:16 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
Thanks to have taken this patch series.
However, I already have in my repository the v3 patch series, whose changelog
- added patches 5, 12, 16
- fixed warning (unused variable) (patch 11)
- added #defines for constants for deleted byte following Philippe remarks
- added #define and explanations for OEM name following Philippe remarks (patch
- small changes following Kevin remarks (patches 3, 5, 6)
- use g_utf8_* functions instead of ad-hock code (patches 8 and 9)
- fix a bug with filenames starting with a dot (patch 9)
Hervé Poussineau (16):
vvfat: fix qemu-img map and qemu-img convert
vvfat: replace tabs by 8 spaces
vvfat: fix typos
vvfat: rename useless enumeration values
vvfat: add constants for special values of name
vvfat: introduce offset_to_bootsector, offset_to_fat and
vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors
vvfat: always create . and .. entries at first and in that order
vvfat: correctly create long names for non-ASCII filenames
vvfat: correctly create base short names for non-ASCII filenames
vvfat: correctly generate numeric-tail of short file names
vvfat: correctly parse non-ASCII short and long file names
vvfat: limit number of entries in root directory in FAT12/FAT16
vvfat: handle KANJI lead byte 0xe5
vvfat: change OEM name to 'MSWIN4.1'
vvfat: initialize memory after allocating it
Should I rebase on top of your branch, or should I send the v3 as is?
It fixes the last random errors I had in Win9x Scandisk (uninitialized memory).
Le 03/07/2017 à 18:50, Kevin Wolf a écrit :
Am 22.05.2017 um 23:11 hat Hervé Poussineau geschrieben:
This patchset fixes some of issues I encountered when trying to use vvfat, and
bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539
Patch 1 fixes a crash when using 'qemu-img convert'.
Patches 2 to 6 are code cleanup. No functionnal changes.
Patches 7 to 13 fix problems detected by disk checking utilities in read-only
With these patches, vvfat creates valid FAT volumes and can be used with QEMU
Read-write mode is still buggy after this patchset, but at least, I was not
able to crash QEMU anymore.
Note that patch 2 doesn't pass checkpatch.pl, as it changes indentation only.
Thanks, fixed the build error in patch 9 (yet unused variables) and
applied to the block branch.
There were a few more minor comments for this series, but it has been on
the list for long enough and I figured that they can be addressed on