[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-based
Date: Thu, 6 Jul 2017 12:42:24 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 05.07.2017 um 23:08 hat Eric Blake geschrieben:
> We are gradually converting to byte-based interfaces, as they are
> easier to reason about than sector-based.  Continue by converting an
> internal structure (no semantic change), and all references to the
> buffer size.
> Add an assertion that our use of s->granularity >> BDRV_SECTOR_BITS
> (necessary for interaction with sector-based dirty bitmaps, until
> a later patch converts those to be byte-based) does not suffer from
> truncation problems.
> [checkpatch has a false positive on use of MIN() in this patch]
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]