[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] iscsi: use scsi_create_task()

From: John Snow
Subject: Re: [Qemu-block] [PATCH] iscsi: use scsi_create_task()
Date: Thu, 6 Jul 2017 17:37:25 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 06/07/2017 02:35 AM, Marc-André Lureau wrote:
> The function does the same initialization, and matches with
> scsi_free_scsi_task() usage, and qemu doesn't need to know the
> allocator details.

Happy month-iversary for this patch!

Yeah, uh, we should probably not be reaching into this structure
ourselves, huh? I had to look up the iscsi source just to confirm that
we /were/ doing the right thing, but now we won't have to worry about it.

> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: John Snow <address@hidden>

This should be care of... Ronnie, Paolo, and Peter Lieven?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]