[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused functions |
|
Date: |
Thu, 6 Jul 2017 19:43:54 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 07/03/2017 11:10 AM, Eric Blake wrote:
> We had several functions that no one is currently using, and which
> use sector-based interfaces. I'm trying to convert towards byte-based
> interfaces, so it's easier to just drop the unused functions:
>
> bdrv_dirty_bitmap_get_meta
> bdrv_dirty_bitmap_get_meta_locked
> bdrv_dirty_bitmap_reset_meta
> bdrv_dirty_bitmap_meta_granularity
>
> Signed-off-by: Eric Blake <address@hidden>
>
Admittedly I forget entirely why some of these are here, or to be more
precise I forget entirely why they are unused as I remember exactly why
we needed them -- but I forget why we merged them without a caller.
Oh well. If they're unused, they're unused, and can be re-added,
especially if we're changing the underpinnings.
I bet my last review on this email used nearly identical wordings.
I'm CCing Vladimir so he has a chance to see that we're removing
functions that he may have wanted to use for his migration series.
Reviewed-by: John Snow <address@hidden>
- [Qemu-block] [PATCH v4 00/17] make dirty-bitmap byte-based, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 01/17] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 03/17] qcow2: Ensure bitmap serialization is aligned, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 02/17] hbitmap: Rename serialization_granularity to serialization_align, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 04/17] dirty-bitmap: Drop unused functions, Eric Blake, 2017/07/03
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused functions,
John Snow <=
- [Qemu-block] [PATCH v4 06/17] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 05/17] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes, Eric Blake, 2017/07/03
[Qemu-block] [PATCH v4 07/17] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based, Eric Blake, 2017/07/03