[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: fix possible return cod
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard |
Date: |
Mon, 10 Jul 2017 16:56:36 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, 07/10 11:35, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden> (supporter:Block I/O path)
> CC: Fam Zheng <address@hidden> (supporter:Block I/O path)
Maybe use "--noroles"? The parenthesis part is not really useful.
> ---
> block/io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/io.c b/block/io.c
> index ed31810c0a..e5c6dc77d3 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -2464,7 +2464,6 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs,
> int64_t offset,
> assert(max_pdiscard >= bs->bl.request_alignment);
>
> while (count > 0) {
> - int ret;
> int num = count;
>
> if (head) {
> --
> 2.11.0
>
>
Reviewed-by: Fam Zheng <address@hidden>