[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 02/11] block: make write-threshold thread-safe

From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH 02/11] block: make write-threshold thread-safe
Date: Mon, 10 Jul 2017 16:42:20 +0100
User-agent: Mutt/1.8.0 (2017-02-23)

On Thu, Jul 06, 2017 at 06:38:19PM +0200, Paolo Bonzini wrote:
> For simplicity, use bdrv_drained_begin/end to avoid concurrent
> writes to the write threshold, or reading it while it is being set.
> qmp_block_set_write_threshold is protected by the BQL.

I find the commit message misleading: the write threshold code is not
being made thread-safe.

The commit description helps to clear this up, but we need to avoid
thinking "write threshold is thread-safe" because that would lead to
races between bdrv_write_threshold_set() callers.


  block: protect write threshold qmp cmd from concurrent requests


Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]