Re: [Qemu-block] [PATCH 02/11] block: make write-threshold thread-safe

[Stefan Hajnoczi]

On Thu, Jul 06, 2017 at 06:38:19PM +0200, Paolo Bonzini wrote:
> For simplicity, use bdrv_drained_begin/end to avoid concurrent
> writes to the write threshold, or reading it while it is being set.
> qmp_block_set_write_threshold is protected by the BQL.

I find the commit message misleading: the write threshold code is not
being made thread-safe.

The commit description helps to clear this up, but we need to avoid
thinking "write threshold is thread-safe" because that would lead to
races between bdrv_write_threshold_set() callers.

Perhaps:

  block: protect write threshold qmp cmd from concurrent requests

Anyway:

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature