[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 5/9] block: List anonymous device BBs in query-b
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH 5/9] block: List anonymous device BBs in query-block |
Date: |
Thu, 13 Jul 2017 13:25:43 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 12.07.2017 um 17:47 hat Eric Blake geschrieben:
> On 07/12/2017 07:57 AM, Kevin Wolf wrote:
> > Instead of listing only monitor-owned BlockBackends in query-block, also
> > add those anonymous BlockBackends that are owned by a qdev device and as
> > such under the control of the user.
> >
> > This allows to use query-block to inspect BlockBackends for the modern
>
> "allows to VERB" is not idiomatic; better is "allows VERBing" (as in
> "allows using query-block"); or "allows SUBJECT to VERB" (as in the
> verbose "allows the client to use query-block").
Is this inconsistency a known problem in English or should we file a new
bug report against it? But as long as this isn't fixed yet, I'll apply
your workaround.
Kevin
pgp4v18qrz1Yo.pgp
Description: PGP signature
- [Qemu-block] [PATCH 1/9] block: Make blk_get_attached_dev_id() public, (continued)
- [Qemu-block] [PATCH 1/9] block: Make blk_get_attached_dev_id() public, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 3/9] block: Make blk_all_next() public, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 2/9] block/qapi: Add qdev device name to query-block, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 4/9] block/qapi: Use blk_all_next() for query-block, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 5/9] block: List anonymous device BBs in query-block, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 7/9] scsi-disk: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 8/9] qemu-iotests: Test 'info block', Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 9/9] qemu-iotests: Test unplug of -device without drive, Kevin Wolf, 2017/07/12