[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PULL 50/85] qcow2: add .bdrv_remove_persi

From: Peter Maydell
Subject: Re: [Qemu-block] [Qemu-devel] [PULL 50/85] qcow2: add .bdrv_remove_persistent_dirty_bitmap
Date: Fri, 14 Jul 2017 13:08:36 +0100

On 14 July 2017 at 13:04, Vladimir Sementsov-Ogievskiy
<address@hidden> wrote:
> 14.07.2017 13:42, Peter Maydell wrote:
> Coverity points out that this can crash in the error-exit paths,
> because bitmap_free() doesn't handle being passed a NULL pointer.
> (CID 1377700).
> Probably the best fix for this is to make bitmap_free() do
> nothing when handed NULL.
> Agree, my stupid omission. Can this be fixed in flight?

No, this code has already hit master -- you'll need to send
a fresh patch to fix it.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]