[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] nbd: Fix iotests failure due to changed client

From: John Snow
Subject: Re: [Qemu-block] [PATCH] nbd: Fix iotests failure due to changed client error message
Date: Mon, 17 Jul 2017 14:12:13 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/17/2017 10:23 AM, Eric Blake wrote:
> Commit 8ecaeae8 changed the way the client requests an NBD export,
> and in the process also changed the resulting error message when
> the export is not present, breaking a couple of iotests.  The error
> message is now directly given by the server (a failed NBD_OPT_GO)
> instead of implied by the client (after exhausting NBD_OPT_LIST),
> but looking at the testsuite changes, it proves worthwhile to
> reword the error message to be slightly less verbose (as this is
> one particular error message likely to be hit by a user).
> Note that the error message is now sensitive to which binary is
> running the server as well as the client (since the expected
> output is replaying a message received from the server); in
> general iotests are run on client and server from the same source
> code base, but if it proves problematic in practice, we'll have
> to tweak or sanitize the output somehow.
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>

Thanks, fixes it up for me.

Tested-by: John Snow <address@hidden>
Reviewed-by: John Snow <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]