[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.10 07/10] migration: Clean up around tls_c
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname |
Date: |
Tue, 18 Jul 2017 16:57:24 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 18, 2017 at 03:41:23PM +0200, Markus Armbruster wrote:
> Optional MigrationParameters members tls_creds and tls_hostname can't
> actually be absent outside qmp_migrate_set_parameters() since commit
> 4af245d (v2.9.0).
>
> Note that commit 4af245d reverted the part of commit de63ab6 (v2.8.0)
> that made tls_creds and tls_hostname absent instead of "" in the value
> of query-migrate-parameters, even though commit de63ab6 called that a
> mistake. What a mess.
>
> Drop the redundant tests for presence, and update documentation.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hmp.c | 6 ++++--
> migration/migration.c | 4 ++--
> qapi-schema.json | 11 +++++------
> 3 files changed, 11 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-block] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE(), (continued)
- [Qemu-block] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null(), Markus Armbruster, 2017/07/18
- [Qemu-block] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject, Markus Armbruster, 2017/07/18
- [Qemu-block] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname, Markus Armbruster, 2017/07/18
- [Qemu-block] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test, Markus Armbruster, 2017/07/18
- [Qemu-block] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default, Markus Armbruster, 2017/07/18