[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.10 00/10] Correct two minor QMP interface
Re: [Qemu-block] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws
Wed, 19 Jul 2017 08:12:59 +0200
Am 18.07.2017 um 18:08 hat Daniel P. Berrange geschrieben:
> On Tue, Jul 18, 2017 at 03:41:16PM +0200, Markus Armbruster wrote:
> > blockdev-add and migrate-set-parameters overload empty strings to mean
> > something entirely different. See my memo "qapi: Stop abusing
> > "special" values for something entirely different" for details.
> > Message-ID: <address@hidden>
> > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html
> > This series deprecates these usages of "" in favour of JSON null.
> > Because we're so close to the 2.10 freeze, the implementation is
> > intentionally stupid: rewrite null to "" at first opportunity. The
> > proper way to do it would be rewriting "" to null, but that requires
> > fixing up code to work with null. There are TODO comments for that.
> > I'm willing to take care of them in the next development cycle.
> I tested the migrate-set-parameters QMP command with this applied and
> I can still pass "" as the tls-hostname.
> When using query-migrate-parameters we still see "" too.
> So from POV of avoiding regressions for existing usage, we look OK
Opportunity for a follow-up patch: Automate these tests.
- Re: [Qemu-block] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter(), (continued)