[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.10 0/2] Bug fixes from byte-based block st
Re: [Qemu-block] [PATCH for-2.10 0/2] Bug fixes from byte-based block status
Mon, 24 Jul 2017 11:28:22 +0200
Am 21.07.2017 um 20:32 hat Eric Blake geschrieben:
> Series 2-4 of my byte-based conversion missed soft freeze, so they
> are now 2.11 material. However, there are some bug fixes in those
> series that we should fix now in 2.10 (patch 1 from series two
> on dirty bitmaps, patch 2 extracted from "qcow2: Switch qcow2_measure()
> to byte-based iteration" from series three on block status).
Thanks, applied to the block branch.
> I don't know if it is worth enhancing iotest 178 to probe the size
> of a 2T image. The test is simple, and fast when patched:
> $ qemu-img create -f qcow2 -o cluster_size=2M huge 2T
> $ time ./qemu-img measure -O qcow2 -f qcow2 huge
> required size: 335806464
> fully allocated size: 2199359062016
> real 0m0.021s
> user 0m0.017s
> sys 0m0.004s
> but the inf-loop when unpatched is annoying; meanwhile, 'huge' only
> occupies 6 megabytes on disk, so it's not that invasive.
Yes, please follow up with qemu-iotests cases for both bugs. We're only
adding the test after fixing the bug, so a hang in the buggy old code
isn't a problem.