[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 1/3] qemu-iotests: set TES
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test
Mon, 31 Jul 2017 07:03:52 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
On 07/31/2017 12:04 AM, Jeff Cody wrote:
> Right now, all qemu-iotests output data into the same scratch directory,
> and so each tests needs to be responsible for cleanup up its own files.
And, tests must either use unique names or else cannot be run in parallel.
> Have each test use 'scratch/$seq' as its temp directory, so the check
> script can do simple cleanup of removing the whole temporary directory.
It also makes it much nicer for a potential future patch to parallelize
things, now that every tests' temporary files are uniquely named by
virtue of the subdirectory.
> Signed-off-by: Jeff Cody <address@hidden>
> tests/qemu-iotests/check | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
> @@ -300,13 +301,23 @@ do
> export OUTPUT_DIR=$PWD
> if $debug; then
> - (cd "$source_iotests";
> + (
> + cd "$source_iotests";
Pre-existing; but we should check that the 'cd' succeeded (if not, the
rest of the code is at risk of doing things in the wrong directory).
Reviewed-by: Eric Blake <address@hidden>
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Description: OpenPGP digital signature