[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] qemu-iotests/109: Fix lock rac
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] qemu-iotests/109: Fix lock race condition |
Date: |
Tue, 1 Aug 2017 18:16:02 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/01/2017 05:31 PM, Cleber Rosa wrote:
> A race condition is currently present between the clean up attempt of
> the QEMU process and the execution of qemu-img. The actual (bad)
> output is:
>
> -Warning: Image size mismatch!
> -Images are identical.
> +qemu-img: Could not open '<build_dir>/tests/qemu-iotests/scratch/t.raw':
> Failed to get "consistent read" lock
> +Is another process using the image?
>
> A KILL signal is sent to the QEMU process, but qemu-img may begin to
> run before the QEMU process is really gone. qemu-img will then
> attempt to open the TEST_IMG file before it can secure a lock on it.
>
> This attempts a more graceful shutdown, and waits for the QEMU process
> to exit.
>
> Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: John Snow <address@hidden>
Thanks for this, it was driving me batty.