[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 1/7] tests/multiboot: Fix whitespace failure
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 1/7] tests/multiboot: Fix whitespace failure |
Date: |
Fri, 11 Aug 2017 16:05:30 +0200 |
From: Eric Blake <address@hidden>
Commit b43671f8 accidentally broke run_test.sh within tests/multiboot;
due to a subtle change in whitespace.
These two commands produce theh same output (at least, for sane $IFS
of space-tab-newline):
echo -e "address@hidden"
echo -e "...$*..."
But that's only because echo inserts spaces between multiple arguments
(the $@ case), while the $* form gives a single argument to echo with
the spaces already present.
But when converting to printf %b, there are no automatic spaces between
multiple arguments, so we HAVE to use $*.
It doesn't help that run_test.sh isn't part of 'make check'.
Signed-off-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
tests/multiboot/run_test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/multiboot/run_test.sh b/tests/multiboot/run_test.sh
index c8f3da8f37..0278148b43 100755
--- a/tests/multiboot/run_test.sh
+++ b/tests/multiboot/run_test.sh
@@ -26,7 +26,7 @@ run_qemu() {
local kernel=$1
shift
- printf %b "\n\n=== Running test case: $kernel $@ ===\n\n" >> test.log
+ printf %b "\n\n=== Running test case: $kernel $* ===\n\n" >> test.log
$QEMU \
-kernel $kernel \
--
2.13.4
- [Qemu-block] [PULL 0/7] Block/Multiboot patches for 2.10.0-rc3, Kevin Wolf, 2017/08/11
- [Qemu-block] [PULL 1/7] tests/multiboot: Fix whitespace failure,
Kevin Wolf <=
- [Qemu-block] [PULL 2/7] vpc: Check failure of bdrv_getlength(), Kevin Wolf, 2017/08/11
- [Qemu-block] [PULL 4/7] qcow2: Check failure of bdrv_getlength(), Kevin Wolf, 2017/08/11
- [Qemu-block] [PULL 5/7] osdep: Add runtime OFD lock detection, Kevin Wolf, 2017/08/11
- [Qemu-block] [PULL 3/7] qcow2: Drop debugging dump_refcounts(), Kevin Wolf, 2017/08/11
- [Qemu-block] [PULL 6/7] file-posix: Do runtime check for ofd lock API, Kevin Wolf, 2017/08/11
- [Qemu-block] [PULL 7/7] qemu-iotests: fix 185, Kevin Wolf, 2017/08/11
- Re: [Qemu-block] [PULL 0/7] Block/Multiboot patches for 2.10.0-rc3, Peter Maydell, 2017/08/11