[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: add block device shared
From: |
Brian Steffens |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: add block device shared field |
Date: |
Tue, 5 Sep 2017 11:10:55 -0400 |
Thanks for taking a look at the patch and fixing the missing CC
addresses!
> Have you considered extending the 'migrate' command with a list of
> drives instead?
That was my original plan but I thought having information on whether a
device is shared or not could potentially be useful to other systems. If
not then you're right, it would be a lighter touch to add it only to the
'migrate' command.
> In case you haven't seen it, the preferred approach for non-shared
> storage migration is drive-mirror + NBD. The block/migration.c code is
> an older feature that is less flexible. More info on drive-mirror +
> NBD:
I didn't realize drive-mirror + NBD was the preferred approach. Are
there any plans to drop support for the block/migration.c style?