[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 6/6] tests: Add check-qobject for equality te
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 6/6] tests: Add check-qobject for equality tests |
Date: |
Mon, 18 Sep 2017 09:25:07 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/16/2017 01:51 PM, Max Reitz wrote:
> Add a new test file (check-qobject.c) for unit tests that concern
> QObjects as a whole.
>
> Its only purpose for now is to test the qobject_is_equal() function.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/Makefile.include | 4 +-
> tests/check-qobject.c | 315
> +++++++++++++++++++++++++++++++++++++++++++++++++
We're not entirely consistent on our testsuite naming, although I'm fine
with your choice [and there's still the idea floating around in another
thread to split tests into subdirectories by whether they are part of
check-unit or check-qtest]. However, the check-* notation cannot be
automatically covered by .gitignore the way a -test suffix is, so you're
missing a change to tests/.gitignore covering the new test in an in-tree
build.
We have the idea floating around that we want to outlaw in-tree builds
altogether [although I'm not sold on that yet], and/or to generate
.gitignore, but until those land, it doesn't hurt to keep .gitignore
up-to-date. So with that addition,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 1/6] qapi/qnull: Add own header, (continued)
- [Qemu-block] [PATCH v5 1/6] qapi/qnull: Add own header, Max Reitz, 2017/09/16
- [Qemu-block] [PATCH v5 3/6] qapi: Add qobject_is_equal(), Max Reitz, 2017/09/16
- [Qemu-block] [PATCH v5 4/6] block: qobject_is_equal() in bdrv_reopen_prepare(), Max Reitz, 2017/09/16
- [Qemu-block] [PATCH v5 5/6] iotests: Add test for non-string option reopening, Max Reitz, 2017/09/16
- [Qemu-block] [PATCH v5 6/6] tests: Add check-qobject for equality tests, Max Reitz, 2017/09/16
- Re: [Qemu-block] [PATCH v5 6/6] tests: Add check-qobject for equality tests,
Eric Blake <=