[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/5] block: Introduce BdrvChildRole.update_filen
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename |
Date: |
Mon, 25 Sep 2017 12:58:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/25/2017 07:28 AM, Kevin Wolf wrote:
> There is no good reason for bdrv_drop_intermediate() to know the active
> layer above the subchain it is operating on - even more so, because
> the assumption that there is a single active layer above it is not
> generally true.
>
> In order to prepare removal of the active parameter, use a BdrvChildRole
> callback to update the backing file string in the overlay image instead
> of directly calling bdrv_change_backing_file().
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> include/block/block_int.h | 6 ++++++
> block.c | 33 ++++++++++++++++++++++++++++-----
> 2 files changed, 34 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in common.qemu, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename, Kevin Wolf, 2017/09/25
- Re: [Qemu-block] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename,
Eric Blake <=
- [Qemu-block] [PATCH 2/5] commit: Support multiple roots above top node, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 4/5] qemu-iotests: Test commit block job where top has two parents, Kevin Wolf, 2017/09/25
- [Qemu-block] [PATCH 5/5] commit: Remove overlay_bs, Kevin Wolf, 2017/09/25
- Re: [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node, John Snow, 2017/09/25