[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uni
From: |
Michael Roth |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer |
Date: |
Mon, 25 Sep 2017 15:53:51 -0500 |
User-agent: |
alot/0.6 |
Quoting Vladimir Sementsov-Ogievskiy (2017-09-22 09:43:53)
> Without initialization to zero dirty_bitmap field may be not zero
> for a bitmap which should not be stored and
> qcow2_store_persistent_dirty_bitmaps will erroneously call
> store_bitmap for it which leads to SYGSEGV on bdrv_dirty_bitmap_name.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
FYI: this patch has been tagged for stable 2.10.1, but is not yet
upstream. Patch freeze for 2.10.1 is September 27th.
> ---
> block/qcow2-bitmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
> index e8d3bdbd6e..14f41d0427 100644
> --- a/block/qcow2-bitmap.c
> +++ b/block/qcow2-bitmap.c
> @@ -602,7 +602,7 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState
> *bs, uint64_t offset,
> goto fail;
> }
>
> - bm = g_new(Qcow2Bitmap, 1);
> + bm = g_new0(Qcow2Bitmap, 1);
> bm->table.offset = e->bitmap_table_offset;
> bm->table.size = e->bitmap_table_size;
> bm->flags = e->flags;
> --
> 2.11.1
>
>