[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 0/2] Optimize sparse reads over NBD
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 0/2] Optimize sparse reads over NBD |
Date: |
Tue, 7 Nov 2017 12:03:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 07/11/2017 04:09, Eric Blake wrote:
> When I first proposed the NBD extension of structured reads,
> it was in order to more efficiently read sparse files without
> sending lots of zeroes over the wire. These two patches feel
> like a feature addition, and missed soft freeze, so I'm
> reluctant to include them in a 2.11 pull request; on the other
> hand, implementing structured replies without sparse reads is
> a rather incomplete feature addition even if it complies with
> the NBD spec. Since structured replies is a new 2.11 feature,
> I could argue that it is a bug if the new feature does not go
> all the way to sparse reads.
>
> I've posted this as two patches, but welcome opinions on whether
> it should be squashed into one.
I think I agree with pushing this to the next release.
Paolo
> Based-on: address@hidden
> ([PATCH 0/8] various NBD fixes for 2.11)
>
> Eric Blake (2):
> nbd/server: Implement sparse reads atop structured reply
> nbd/server: Optimize final chunk of sparse read
>
> nbd/server.c | 79
> +++++++++++++++++++++++++++++++++++++++++++++++++++++---
> nbd/trace-events | 1 +
> 2 files changed, 77 insertions(+), 3 deletions(-)
>