|
From: | Darren Kenny |
Subject: | Re: [Qemu-block] [PATCH v3 3/7] block/sheepdog: remove spurious NULL check |
Date: | Wed, 8 Nov 2017 10:48:57 +0000 |
User-agent: | NeoMutt/20171027 |
On Tue, Nov 07, 2017 at 05:27:20PM -0500, Jeff Cody wrote:
'tag' is already checked in the lines immediately preceding this check, and set to non-NULL if NULL. No need to check again, it hasn't changed. Signed-off-by: Jeff Cody <address@hidden> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
--- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 696a714..459d93a 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -1632,7 +1632,7 @@ static int sd_open(BlockDriverState *bs, QDict *options, int flags, if (!tag) { tag = ""; } - if (tag && strlen(tag) >= SD_MAX_VDI_TAG_LEN) { + if (strlen(tag) >= SD_MAX_VDI_TAG_LEN) { error_setg(errp, "value of parameter 'tag' is too long"); ret = -EINVAL; goto err_no_fd; -- 2.9.5
[Prev in Thread] | Current Thread | [Next in Thread] |