[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v5 15/20] vdi: Avoid bitrot of debugging code
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v5 15/20] vdi: Avoid bitrot of debugging code |
Date: |
Thu, 30 Nov 2017 19:42:37 -0600 |
Rework the debug define so that we always get -Wformat checking,
even when debugging is disabled.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
v2-v5: no change
---
block/vdi.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index 8da5dfc897..6f83221ddc 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -86,12 +86,18 @@
#define DEFAULT_CLUSTER_SIZE (1 * MiB)
#if defined(CONFIG_VDI_DEBUG)
-#define logout(fmt, ...) \
- fprintf(stderr, "vdi\t%-24s" fmt, __func__, ##__VA_ARGS__)
+#define VDI_DEBUG 1
#else
-#define logout(fmt, ...) ((void)0)
+#define VDI_DEBUG 0
#endif
+#define logout(fmt, ...) \
+ do { \
+ if (VDI_DEBUG) { \
+ fprintf(stderr, "vdi\t%-24s" fmt, __func__, ##__VA_ARGS__); \
+ } \
+ } while (0)
+
/* Image signature. */
#define VDI_SIGNATURE 0xbeda107f
--
2.14.3
- Re: [Qemu-block] [PATCH v5 01/20] block: Add .bdrv_co_block_status() callback, (continued)
- [Qemu-block] [PATCH v5 12/20] qed: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 20/20] block: Drop unused .bdrv_co_get_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 04/20] gluster: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 05/20] iscsi: Switch cluster_sectors to byte-based, Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 17/20] vmdk: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 08/20] null: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 18/20] vpc: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 11/20] qcow2: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 02/20] block: Switch passthrough drivers to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 15/20] vdi: Avoid bitrot of debugging code,
Eric Blake <=
- [Qemu-block] [PATCH v5 09/20] parallels: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 10/20] qcow: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 19/20] vvfat: Switch to .bdrv_co_block_status(), Eric Blake, 2017/12/01
- [Qemu-block] [PATCH v5 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based, Eric Blake, 2017/12/01