[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-io: fix EOF Ctrl-D handling i
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code
Wed, 06 Dec 2017 17:14:27 +0100
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
Eric Blake <address@hidden> writes:
> On 12/06/2017 08:25 AM, Daniel P. Berrange wrote:
>>> Should we instead be looking for a match against the current termios()
>>> c_cc[VEOF] setting, in case the user prefers something other than ^D via
>>> stty? Does readline provide any functionality for automating this?
>> I was afraid someone was going to suggest doing that. I was being lazy by
>> hardcoding Ctrl-D, but yes the real readline() library will honour the
>> VEOF value. QEMU though is using a home-grown reimpl of readline...
> I understand why we can't use modern libreadline (it is licensed GPLv3+,
> making it impossible to use with our GPLv2-only code) - but doesn't BSD
> have a readline-alike library with BSD licensing that we could use
> instead of implementing readline ourselves? (Was it named libinput?)
We've discussed this before. Short story: we can't use the original due
to our foolish licensing mistake, and the clones don't cut the mustard.