[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] blockjob: kick jobs on set-speed
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH v2] blockjob: kick jobs on set-speed |
|
Date: |
Wed, 13 Dec 2017 22:19:37 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 13/12/2017 21:46, John Snow wrote:
>
> When a user provides a new speed, kick the job to allow it to recalculate
> its delay.
>
> Signed-off-by: John Snow <address@hidden>
> ---
>
> RFC: Why is block_job_mutex shared between all jobs,
> instead of being per-job?
Because that patch was partly extracted out of a bigger one, and I was
both lazy and worried about breaking things close to the release.
In other words more uses of the mutex are coming, and it will need to be
shared between jobs to work fine with transactions and monitor commands
(which don't know the job they're working on until they've looked it
up). Starting a paused block job is not a hot path. :)
Paolo