[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 02/19] block: Assert drain_all is only called fr
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH 02/19] block: Assert drain_all is only called from main AioContext |
Date: |
Wed, 20 Dec 2017 20:14:21 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, 12/20 11:33, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/io.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/io.c b/block/io.c
> index cf780c3cb0..b94740b8ff 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -330,6 +330,12 @@ void bdrv_drain_all_begin(void)
> BdrvNextIterator it;
> GSList *aio_ctxs = NULL, *ctx;
>
> + /* BDRV_POLL_WHILE() for a node can only be called from its own I/O
> thread
> + * or the main loop AioContext. We potentially use BDRV_POLL_WHILE() on
> + * nodes in several different AioContexts, so make sure we're in the main
> + * context. */
> + assert(qemu_get_current_aio_context() == qemu_get_aio_context());
> +
> block_job_pause_all();
>
> for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
> --
> 2.13.6
>
Reviewed-by: Fam Zheng <address@hidden>
- [Qemu-block] [PATCH 00/19] Drain fixes and cleanups, part 2, Kevin Wolf, 2017/12/20
- [Qemu-block] [PATCH 04/19] test-bdrv-drain: Test callback for bdrv_drain, Kevin Wolf, 2017/12/20
- [Qemu-block] [PATCH 05/19] test-bdrv-drain: Test bs->quiesce_counter, Kevin Wolf, 2017/12/20
- [Qemu-block] [PATCH 07/19] test-bdrv-drain: Test drain vs. block jobs, Kevin Wolf, 2017/12/20
- [Qemu-block] [PATCH 08/19] block: Don't block_job_pause_all() in bdrv_drain_all(), Kevin Wolf, 2017/12/20
- [Qemu-block] [PATCH 06/19] blockjob: Pause job on draining any job BDS, Kevin Wolf, 2017/12/20