[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 13/14] block: Document that x-blockdev-change breaks
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 13/14] block: Document that x-blockdev-change breaks quorum children list |
Date: |
Wed, 20 Dec 2017 14:19:38 +0100 |
Removing a quorum child node with x-blockdev-change results in a quorum
driver state that cannot be recreated with create options because it
would require a list with gaps. This causes trouble in at least
.bdrv_refresh_filename().
Document this problem so that we won't accidentally mark the command
stable without having addressed it.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
qapi/block-core.json | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index dd763dcf87..4cc1389834 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3918,6 +3918,10 @@
# does not support all kinds of operations, all kinds of children, nor
# all block drivers.
#
+# FIXME Removing children from a quorum node means introducing gaps in the
+# child indices. This cannot be represented in the 'children' list of
+# BlockdevOptionsQuorum, as returned by .bdrv_refresh_filename().
+#
# Warning: The data in a new quorum child MUST be consistent with that of
# the rest of the array.
#
--
2.13.6
- [Qemu-block] [PULL 03/14] iotests: fix 197 for vpc, (continued)
- [Qemu-block] [PULL 03/14] iotests: fix 197 for vpc, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 04/14] block: Make bdrv_drain_invoke() recursive, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 05/14] block: Call .drain_begin only once in bdrv_drain_all_begin(), Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 07/14] block: bdrv_drain_recurse(): Remove unused begin parameter, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 06/14] test-bdrv-drain: Test BlockDriver callbacks for drain, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 08/14] block: Don't wait for requests in bdrv_drain*_end(), Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 10/14] qemu-img: Document --force-share / -U, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 09/14] block: Unify order in drain functions, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 11/14] block: Don't acquire AioContext in hmp_qemu_io(), Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 12/14] qcow2: get rid of qcow2_backing_read1 routine, Kevin Wolf, 2017/12/20
- [Qemu-block] [PULL 13/14] block: Document that x-blockdev-change breaks quorum children list,
Kevin Wolf <=
- [Qemu-block] [PULL 14/14] nvme: Add tracing, Kevin Wolf, 2017/12/20
- Re: [Qemu-block] [Qemu-devel] [PULL 00/14] Block layer patches, Peter Maydell, 2017/12/20