[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called from main AioContext |
Date: |
Mon, 08 Jan 2018 17:09:19 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 21 Dec 2017 03:22:34 PM CET, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> ---
> block/io.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/io.c b/block/io.c
> index cf780c3cb0..b94740b8ff 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -330,6 +330,12 @@ void bdrv_drain_all_begin(void)
> BdrvNextIterator it;
> GSList *aio_ctxs = NULL, *ctx;
>
> + /* BDRV_POLL_WHILE() for a node can only be called from its own I/O
> thread
> + * or the main loop AioContext. We potentially use BDRV_POLL_WHILE() on
> + * nodes in several different AioContexts, so make sure we're in the main
> + * context. */
> + assert(qemu_get_current_aio_context() == qemu_get_aio_context());
> +
> block_job_pause_all();
Reviewed-by: Alberto Garcia <address@hidden>
Berto
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called from main AioContext,
Alberto Garcia <=