[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 3/9] block: Add VFIO based NVMe driver
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v4 3/9] block: Add VFIO based NVMe driver |
Date: |
Thu, 11 Jan 2018 14:48:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 10/01/2018 19:33, Stefan Hajnoczi wrote:
>> +
>> + /* Fields protected by @lock */
> Does this lock serve any purpose? I didn't see a place where these
> fields is accessed from multiple threads. Perhaps you're trying to
> prepare for multiqueue, but then other things like the
> BDRVNVMeState->inflight counter aren't protected so it doesn't make
> sense.
>
Other drivers are already thread safe (e.g. block/vdi.c since commit
1e88663979, "vdi: make it thread-safe", 2017-07-17). So I'd be in favor
of (fixing and) keeping the lock.
Paolo
- Re: [Qemu-block] [PATCH v4 2/9] util: Introduce vfio helpers, (continued)
- [Qemu-block] [PATCH v4 3/9] block: Add VFIO based NVMe driver, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 4/9] block: Introduce buf register API, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 5/9] block/nvme: Implement .bdrv_(un)register_buf, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 6/9] qemu-img: Map bench buffer, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 8/9] docs: Add section for NVMe VFIO driver, Fam Zheng, 2018/01/10
- [Qemu-block] [PATCH v4 7/9] block: Move NVMe constants to a separate header, Fam Zheng, 2018/01/10