Re: [Qemu-block] [PATCH] iotests: 205: support luks format

[Vladimir Sementsov-Ogievskiy]

06.02.2018 21:04, Eric Blake wrote:
> On 02/06/2018 11:57 AM, Vladimir Sementsov-Ogievskiy wrote:
>
> > > > +luks_default_secret_id = 'luks_secret_default_iotests_id'
> > > Can we just call this  "keysec0", so we matchh convention used by
> > > the shell script based tests.
> >
> > Here I'm trying to avoid intersection with some user-defined id.
>
> You're overthinking it.  We are only using this in the testsuite, and 
> nothing else in the testsuite is using 'keysec0' for anything except 
> the id of the secret to pass to encrypted disks.  The longer name 
> doesn't add any protection.  It might be different if we were trying 
> to provide a reusable library for contexts outside the testsuite, but 
> since we are not doing that, we can rely on 'make check' failing as 
> evidence if we have any collisions in naming choices that need long 
> name munging as a workaround.

Ok

--
Best regards,
Vladimir