[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 25/27] block: Fail bdrv_truncate() with negative siz
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH 25/27] block: Fail bdrv_truncate() with negative size |
Date: |
Thu, 8 Feb 2018 20:23:26 +0100 |
Most callers have their own checks, but something like this should also
be checked centrally. As it happens, x-blockdev-create can pass negative
image sizes to format drivers (because there is no QAPI type that would
reject negative numbers) and triggers the check added by this patch.
Signed-off-by: Kevin Wolf <address@hidden>
---
block.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block.c b/block.c
index 725c33e53f..59e74a5ebc 100644
--- a/block.c
+++ b/block.c
@@ -3681,6 +3681,11 @@ int bdrv_truncate(BdrvChild *child, int64_t offset,
PreallocMode prealloc,
error_setg(errp, "No medium inserted");
return -ENOMEDIUM;
}
+ if (offset < 0) {
+ error_setg(errp, "Image size cannot be negative");
+ return -EINVAL;
+ }
+
if (!drv->bdrv_truncate) {
if (bs->file && drv->is_filter) {
return bdrv_truncate(bs->file, offset, prealloc, errp);
--
2.13.6
- [Qemu-block] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object, (continued)
- [Qemu-block] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 21/27] ssh: QAPIfy host-key-check option, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 22/27] ssh: Pass BlockdevOptionsSsh to connect_to_ssh(), Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 23/27] ssh: Support .bdrv_co_create, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 24/27] file-posix: Fix no-op bdrv_truncate() with falloc preallocation, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 25/27] block: Fail bdrv_truncate() with negative size,
Kevin Wolf <=
- [Qemu-block] [PATCH 26/27] qemu-iotests: Test qcow2 over file image creation with QMP, Kevin Wolf, 2018/02/08
- [Qemu-block] [PATCH 27/27] qemu-iotests: Test ssh image creation over QMP, Kevin Wolf, 2018/02/08