[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to Block
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver |
Date: |
Thu, 22 Feb 2018 16:30:15 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 22 Feb 2018 04:19:45 PM CET, Max Reitz wrote:
> On 2018-02-06 16:23, Alberto Garcia wrote:
>> On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote:
>>> --- a/block/blkdebug.c
>>> +++ b/block/blkdebug.c
>>> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState
>>> *reopen_state,
>>> return 0;
>>> }
>>>
>>> +static const char *const blkdebug_sgfnt_runtime_opts[] = {
>>> + "config",
>>> + "inject-error.",
>>> + "set-state.",
>>> + "suspend.",
>>
>> Where did this "suspend." come from?
>
> Er, well, er.
>
> After having looked at it a couple of times now, I can't see anything.
> I guess I'll remove it and hope for the best...?
My interpretation is that you saw
enum {
ACTION_INJECT_ERROR,
ACTION_SET_STATE,
ACTION_SUSPEND,
};
and assumed that "suspend" was an option (the other two are). I haven't
seen any string with the "suspend" text anywhere else in the code.
Berto
- [Qemu-block] [PATCH v8 11/26] block: Add bdrv_dirname(), (continued)
- [Qemu-block] [PATCH v8 11/26] block: Add bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 16/26] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 17/26] iotests: Add quorum case to test 110, Max Reitz, 2018/02/05
- [Qemu-block] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Max Reitz, 2018/02/05
- Re: [Qemu-block] [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Eric Blake, 2018/02/06
[Qemu-block] [PATCH v8 19/26] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 20/26] block: Generically refresh runtime options, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 22/26] block: Do not copy exact_filename from format file, Max Reitz, 2018/02/05
[Qemu-block] [PATCH v8 24/26] block/curl: Harmonize option defaults, Max Reitz, 2018/02/05