[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create op

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create option
Date: Fri, 23 Feb 2018 00:43:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 2018-02-21 14:53, Kevin Wolf wrote:
> The "redundacy" option for Sheepdog image creation is currently a string
> that can encode one or two integers depending on its format, which at
> the same time implicitly selects a mode.
> This patch turns it into a QAPI union and converts the string into such
> a QAPI object before interpreting the values.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  qapi/block-core.json | 45 +++++++++++++++++++++++++
>  block/sheepdog.c     | 94 
> +++++++++++++++++++++++++++++++++++++---------------
>  2 files changed, 112 insertions(+), 27 deletions(-)

Ooooh, thanks!

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]