Re: [Qemu-block] [PATCH v2 36/36] qemu-iotests: Test ssh image creation over QMP

[Max Reitz]

On 2018-02-21 14:54, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/207     | 261 
> +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/207.out |  75 +++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 337 insertions(+)
>  create mode 100755 tests/qemu-iotests/207
>  create mode 100644 tests/qemu-iotests/207.out

Minor note: If this test tried to create a qcow2 image over ssh, it
would have seen "Image format driver does not support resize" without
the ssh truncation patches.

But I'm not sure whether such a test case should be added here, because
technically this test then becomes a qcow2+ssh test, and nobody is ever
going to run the iotests with the qcow2+ssh combination.

(We could cheat and still mark this test as raw and then just create a
qcow2 image nonetheless...)

Max

signature.asc
Description: OpenPGP digital signature