[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram
Date: Thu, 8 Mar 2018 11:32:44 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/06/2018 10:00 AM, Stefan Hajnoczi wrote:
On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:

01: add block_latency_histogram_clear()
02: fix spelling (sorry =()
     some rewordings
     remove histogram if latency parameter unspecified

Vladimir Sementsov-Ogievskiy (2):
   block/accounting: introduce latency histogram
   qapi: add block latency histogram interface

  qapi/block-core.json       | 73 +++++++++++++++++++++++++++++++++-
  include/block/accounting.h |  9 +++++
  block/accounting.c         | 97 ++++++++++++++++++++++++++++++++++++++++++++++
  block/qapi.c               | 31 +++++++++++++++
  blockdev.c                 | 19 +++++++++
  5 files changed, 228 insertions(+), 1 deletion(-)

The feature looks good.  I posted documentation and code readability

I also think it makes sense; if a v3 hits the list in time, I will probably include it in my last QAPI pull before softfreeze.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]