[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 5/7] vdi: Support .bdrv_co_create

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 5/7] vdi: Support .bdrv_co_create
Date: Mon, 12 Mar 2018 22:22:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 2018-03-09 22:46, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to vdi, which
> enables image creation over QMP.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  qapi/block-core.json |  21 ++++++-
>  block/vdi.c          | 169 
> ++++++++++++++++++++++++++++++++++++++-------------
>  2 files changed, 148 insertions(+), 42 deletions(-)

As I said on IRC, I'd prefer cluster-size not to be exposed over QAPI,
seeing it is not supported by default (and you can't enable it through
configure, you can only enable it by modifying vdi.c), and that it is
explicitly untested.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]