[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

From: Fam Zheng
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath
Date: Thu, 15 Mar 2018 15:08:59 +0800
User-agent: Mutt/1.9.2 (2017-12-15)

On Wed, 03/14 09:47, Eric Blake wrote:
> > The remaining use was using realpath to convert a possibly
> > relative filename into an absolute one before calling diff,
> > but diff works just fine on the relative name.
> Hmm, this last change reverts commit 93e53fb6 that added realpath on purpose
> for ease of diagnosing failed tests.  Maybe it's worth a v2 that tests
> whether realpath exists, and if so uses it, but does a safe fallback to just
> using the filename as-is.

Yes, thanks for spotting that. I am used to do out-of-tree builds/tests and
modifying XXX.out files by copying from .out.bad. Having realpath saves some
typing so..

Your fallback idea sounds good to me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]