[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH for-2.12 01/12] vdi: Change 'static' create opti

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH for-2.12 01/12] vdi: Change 'static' create option to 'preallocation' in QMP
Date: Tue, 20 Mar 2018 13:09:00 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/20/2018 12:36 PM, Kevin Wolf wrote:
What static=on really does is what we call metadata preallocation for
other block drivers. While we can still change the QMP interface, make
it more consistent by using 'preallocation' for VDI, too.

The x- naming of the command means we don't HAVE to get this patch in for 2.12, but I agree that sooner is better than later and that doing this in 2.12 is worth the effort.

This doesn't implement any new functionality, so the only supported
preallocation modes are 'off' and 'metadata' for now.

Signed-off-by: Kevin Wolf <address@hidden>
  qapi/block-core.json |  6 ++----
  block/vdi.c          | 24 ++++++++++++++++++++++--
  2 files changed, 24 insertions(+), 6 deletions(-)

+++ b/qapi/block-core.json
@@ -3834,16 +3834,14 @@
  # @file             Node to create the image format on
  # @size             Size of the virtual disk in bytes
-# @static           Whether to create a statically (true) or
-#                   dynamically (false) allocated image
-#                   (default: false, i.e. dynamic)
+# @preallocation    Preallocation mode for the new image (default: off)

Do we want to document that 'full' is not supported yet? Or is just relying on the error message good enough?

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]