[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH for-2.12 09/12] vhdx: Require power-of-two block

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create
Date: Tue, 20 Mar 2018 13:43:33 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/20/2018 12:36 PM, Kevin Wolf wrote:
Images with a non-power-of-two block size are invalid and cannot be
opened. Reject such block sizes when creating an image.

Signed-off-by: Kevin Wolf <address@hidden>
  block/vhdx.c | 4 ++++
  1 file changed, 4 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

diff --git a/block/vhdx.c b/block/vhdx.c
index f1b97f4b49..ca211a3196 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1877,6 +1877,10 @@ static int coroutine_fn 
vhdx_co_create(BlockdevCreateOptions *opts,
          error_setg_errno(errp, EINVAL, "Block size must be a multiple of 1 
          return -EINVAL;
+    if (!is_power_of_2(block_size)) {
+        error_setg(errp, "Block size must be a power of two");
+        return -EINVAL;
+    }
      if (block_size > VHDX_BLOCK_SIZE_MAX) {
          error_setg_errno(errp, EINVAL, "Block size must not exceed %d",

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]