[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 2/4] nbd/server: add nbd_meta_single_query helpe

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper
Date: Wed, 21 Mar 2018 10:05:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
The helper will be reused for bitmaps namespace.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  nbd/server.c | 41 ++++++++++++++++++++++++++++-------------
  1 file changed, 28 insertions(+), 13 deletions(-)

+/* Read len bytes and check matching to the pattern.
+ * @match is set to true on empty query for _LIST_ and for query matching the
+ * @pattern. @match is never set to false.

How about:

Read @len bytes, and set @match to true if they match @pattern, or if @len is 0 and the client is performing _LIST_. @match is never set to false.

At any rate, the refactoring is sane; and comment touchups are trivial, so

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]